Add Boqun Feng to opsem meetings ping group #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JakobDegen or @RalfJung In order to merge this we need to change the validation to allow people to only be part of Zulip user groups. Currently CI fails if the person is not a member of a team or has a specific permission. |
RalfJung
previously approved these changes
Mar 6, 2023
RalfJung
approved these changes
Nov 19, 2023
No problem! And kindly ping @rylev ;-)
Thanks!
|
|
This has the same issue as #1120 - we don't allow people who are not a member of any team to be a part of these groups. I think we'll want to loosen this restriction though. cc @Mark-Simulacrum |
|
CI should be fixed by #1124, can you rebase? |
Thanks! And done |
jackh726
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.